Codestin Search App

nikophil · 2018-12-20T17:26:15Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT

Hi,

here is a little improvement for the choice constraint: expose a new choices wildcard for the messages, in order to provide a way to display easily the valid choices to the user.

thanks.

HeahDude · 2018-12-20T17:50:21Z

This can be closed as this feature is supported by the annotation reader already, just remove the quotes :).

 /**
     * @var string
     *
     * @Assert\Choice(choices=App\Constants::AVAILABLE_STATES)
     */
    private $state;

yceruto · 2018-12-20T18:02:56Z

@HeahDude Do you meant @Assert\Choice(choices=App\Constants::AVAILABLE_STATES)?

HeahDude · 2018-12-20T18:04:58Z

yes x).

HeahDude · 2018-12-20T21:50:50Z

src/Symfony/Component/Validator/Constraints/ChoiceValidator.php

        } elseif (!\in_array($value, $choices, true)) {
            $this->context->buildViolation($constraint->message)
                ->setParameter('{{ value }}', $this->formatValue($value))
+                ->setParameter('{{ choices }}', implode(', ', $choices))


Ah this line is still a nice addition indeed!

nikophil · 2018-12-21T09:11:17Z

yeah indeed, you're right, and i 've learnt something new :)
will we keep the new wildcard choices i've added, or should i close the PR ?

HeahDude · 2018-12-21T09:33:17Z

I'm 👍 for supporting a default choices implode, as long as we don't change the default message for both BC and let it opt-in performance wise.

nikophil · 2018-12-21T09:37:31Z

i've updated the PR

ro0NL · 2018-12-21T10:49:21Z

src/Symfony/Component/Validator/Constraints/ChoiceValidator.php

        } elseif (!\in_array($value, $choices, true)) {
            $this->context->buildViolation($constraint->message)
                ->setParameter('{{ value }}', $this->formatValue($value))
+                ->setParameter('{{ choices }}', implode(', ', $choices))


should also be added to the multiple=true case

choices can be any value, i think we need to map all choices using formatValue() also.

yep, you're totally right - i've added to the multiple=true case and formatted the value

xabbuh · 2018-12-27T11:04:32Z

@nikophil Can you please update the PR title and description to match the recent changes (they will be part of the git history)?

nikophil · 2018-12-27T11:08:03Z

done 👍

fabpot · 2019-01-02T09:34:34Z

Thank you @nikophil.

This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] Choices constraint improvement | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Hi, here is a little improvement for the choice constraint: expose a new `choices` wildcard for the messages, in order to provide a way to display easily the valid choices to the user. thanks. Commits ------- 71dfa35 add new `choices` wildcard in message

…int (nikophil) This PR was submitted for the 3.4 branch but it was merged into the master branch instead (closes #10836). Discussion ---------- document "choices" wildcard in Choice validation constraint Hello, here is a little doc update in order to document the `choices` wildcard introduced by symfony/symfony#29658 Commits ------- 7764519 document "choices" wildcard in Choice validation constraint

…ation (nikophil) This PR was squashed before being merged into the 3.4 branch (closes #10810). Discussion ---------- [Validator] Explained how to use array constant in annotation Hi, few days ago i tried to add a new feature to the `choice` validator constraint, by adding a new `choicesFromConstant` option. symfony/symfony#29658 But then, i realized this was already supported. I think this should be documented, as i think a lot of people don't know this feature. thanks. Commits ------- 7774aab [Validator] Explained how to use array constant in annotation

It was added in this PR: symfony/symfony#29658

…s (przemyslaw-bogusz) This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #13081). Discussion ---------- [Constraints][Choice] Added choices to message parameters It was added in this PR: symfony/symfony#29658  Commits ------- 3ba67f7 Added choices to message parameters

carsonbot added Status: Needs Review Validator Feature labels Dec 20, 2018

HeahDude reviewed Dec 21, 2018

View reviewed changes

ro0NL reviewed Dec 21, 2018

View reviewed changes

nicolas-grekas added this to the next milestone Dec 24, 2018

add new choices wildcard in message

71dfa35

xabbuh approved these changes Dec 27, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Dec 27, 2018

HeahDude approved these changes Dec 27, 2018

View reviewed changes

nikophil mentioned this pull request Dec 27, 2018

[Validator] Explained how to use array constant in annotation symfony/symfony-docs#10810

Closed

fabpot approved these changes Jan 2, 2019

View reviewed changes

fabpot merged commit 71dfa35 into symfony:master Jan 2, 2019

nikophil mentioned this pull request Jan 3, 2019

document "choices" wildcard in Choice validation constraint symfony/symfony-docs#10836

Closed

nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

fabpot mentioned this pull request May 9, 2019

Release v4.3.0-BETA1 #31435

Merged

przemyslaw-bogusz added a commit to przemyslaw-bogusz/symfony-docs that referenced this pull request Feb 8, 2020

Added choices to message parameters

8afff5d

It was added in this PR: symfony/symfony#29658

przemyslaw-bogusz mentioned this pull request Feb 8, 2020

[Constraints][Choice] Added choices to message parameters symfony/symfony-docs#13081

Merged

javiereguiluz pushed a commit to przemyslaw-bogusz/symfony-docs that referenced this pull request Feb 10, 2020

Added choices to message parameters

3ba67f7

It was added in this PR: symfony/symfony#29658

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Validator] Choices constraint improvement #29658

[Validator] Choices constraint improvement #29658
fabpot merged 1 commit intosymfony:masterfrom
nikophil:validator-choice-constant

nikophil commented Dec 20, 2018 •

edited

Loading

Uh oh!

HeahDude commented Dec 20, 2018 •

edited

Loading

Uh oh!

yceruto commented Dec 20, 2018

Uh oh!

HeahDude commented Dec 20, 2018

Uh oh!

HeahDude Dec 20, 2018

Uh oh!

nikophil commented Dec 21, 2018

Uh oh!

HeahDude commented Dec 21, 2018

Uh oh!

nikophil commented Dec 21, 2018

Uh oh!

ro0NL Dec 21, 2018

Uh oh!

nikophil Dec 27, 2018

Uh oh!

xabbuh commented Dec 27, 2018

Uh oh!

nikophil commented Dec 27, 2018

Uh oh!

fabpot commented Jan 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

nikophil commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HeahDude commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yceruto commented Dec 20, 2018

Uh oh!

HeahDude commented Dec 20, 2018

Uh oh!

HeahDude Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

nikophil commented Dec 21, 2018

Uh oh!

HeahDude commented Dec 21, 2018

Uh oh!

nikophil commented Dec 21, 2018

Uh oh!

ro0NL Dec 21, 2018

Choose a reason for hiding this comment

Uh oh!

nikophil Dec 27, 2018

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Dec 27, 2018

Uh oh!

nikophil commented Dec 27, 2018

Uh oh!

fabpot commented Jan 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nikophil commented Dec 20, 2018 •

edited

Loading

HeahDude commented Dec 20, 2018 •

edited

Loading