kriswallsmith: AsseticBundle config additions for lessphp filter #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: Requires kriswallsmith/assetic#19 |
|
As I commented over there you might want to add the file to include via the DIC: |
|
yes, working on that change |
…e if file name defined
| @@ -57,6 +57,9 @@ class AsseticExtension extends Extension | |||
| $container->setParameter('assetic.yui_jar', $config['yui']); | |||
| $loader->load('yui_compressor.xml'); | |||
| } | |||
| if (isset($config['lessphp_file'])) { | |||
There was a problem hiding this comment.
maybe it would make sense to use an array of files here? just for forwards compatibility?
file:
lessphp: ..
|
Let's re-open this once the patch is merged into Assetic. |
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
Add Symfony's May 2018 advisories
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Sep 24, 2020
Changelog for 0.7.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the config change to make the new assetic filter for lessphp available in symfony