[Twig][Bootstrap 4 Theme]: Displaying errors like in official components/forms #29987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlashBlack
commented
Jan 25, 2019
•
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | Yes |
| Fixed tickets | #28086 #29986 |
| License | MIT |
| Doc PR | — |
3a104ed to
f506da2
Compare
f506da2 to
566a445
Compare
vudaltsov
suggested changes
Feb 11, 2019
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
Outdated
Show resolved
Hide resolved
5c94471 to
a8d74c5
Compare
vudaltsov
approved these changes
Mar 6, 2019
|
Thank you for this PR. I like that you addressed the issue but we also need to consider accessibility. I suggest closing this PR and solve it like described here: #28086 (comment) I would be more than happy to review a new PR form you. #eu-fossa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.