[PropertyAccess] speed up accessing object properties#29999
Merged
fabpot merged 1 commit intosymfony:masterfrom Jan 30, 2019
Merged
[PropertyAccess] speed up accessing object properties#29999fabpot merged 1 commit intosymfony:masterfrom
fabpot merged 1 commit intosymfony:masterfrom
Conversation
Contributor
|
As this provide almost identical performance boost (~ 20/30% perf improvement). I would prefer merging this and do further profiling to improve serializer performance. |
ostrolucky
reviewed
Jan 27, 2019
| self::VALUE => $objectOrArray, | ||
| ]; | ||
|
|
||
| if (\is_object($objectOrArray) && false === strpos((string) $propertyPath, '.') && false === strpos((string) $propertyPath, '[')) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (\is_object($objectOrArray) && false === strpos((string) $propertyPath, '.') && false === strpos((string) $propertyPath, '[')) { | |
| if (\is_object($objectOrArray) && false === strpbrk((string) $propertyPath, '.[')) { |
Member
Author
There was a problem hiding this comment.
Updated, though I wonder if using strcspn() and comparing that with strlen() would be better in that it doesn't required to copy a string.
Contributor
There was a problem hiding this comment.
According to https://blackfire.io/profiles/compare/f5b0113a-fcae-41cc-9b83-3bdd48c8bcf5/graph using strpbrk is faster than strcspn + strlen.
7 tasks
Contributor
|
Here is a profile of this PR (with @ostrolucky suggestions ; single |
fbourigault
approved these changes
Jan 27, 2019
dunglas
approved these changes
Jan 28, 2019
vudaltsov
approved these changes
Jan 29, 2019
fabpot
approved these changes
Jan 30, 2019
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2019
…(xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [PropertyAccess] speed up accessing object properties | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28926, #29405 | License | MIT | Doc PR | I propose to improve the performance of the `ObjectNormalizer` by not adding a new interface to the PropertyAccess component, but by adding some shortcut for cases where we know that we do not need to perform all checks. The added benefit is that this will not only speed up the `ObjectNormalizer` class, but will be available for every consumer of the `PropertyAccessor` without having to adapt to a new API. TODO: - [ ] confirm that these changes indeed introduce the same benefit as #29405 doing an actual benchmark Commits ------- ef7876e speed up accessing object properties
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to improve the performance of the
ObjectNormalizerby not adding a new interface to the PropertyAccess component, but by adding some shortcut for cases where we know that we do not need to perform all checks. The added benefit is that this will not only speed up theObjectNormalizerclass, but will be available for every consumer of thePropertyAccessorwithout having to adapt to a new API.TODO: