[Security] Replace serialization API#30052
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Feb 7, 2019
renanbr:serialization-strategy
Merged
[Security] Replace serialization API#30052nicolas-grekas merged 1 commit intosymfony:masterfrom renanbr:serialization-strategy
nicolas-grekas merged 1 commit intosymfony:masterfrom
renanbr:serialization-strategy
Conversation
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Looks great thanks. Here are some minor comments.
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Exception/AuthenticationException.php
Outdated
Show resolved
Hide resolved
Member
|
Don't forget to update UPGRADE-4.3 and the CHANGELOG of the component also! |
Member
it does not actually so there is no BC break (and serialized payloads are kept compatible) - the PR description should be updated. |
nicolas-grekas
approved these changes
Feb 1, 2019
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
(with one minor comment)
chalasr
approved these changes
Feb 4, 2019
ro0NL
reviewed
Feb 5, 2019
Member
|
@renanbr Looks like this PR needs a rebase as it contains unrelated changes now. |
Member
|
Thank you @renanbr. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Security] Replace serialization API | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a New `getState()` and `setState()` methods in `AbstractToken` and `AuthenticationException` allow users to append data to the serialization payload. It allow us to have zero impact in user land when changing the serialization engine. Commits ------- 006c6dd makes serialize methods final
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
getState()andsetState()methods inAbstractTokenandAuthenticationExceptionallow users to append data to the serialization payload.It allow us to have zero impact in user land when changing the serialization engine.