[Messenger] Fix DataCollector template #30078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Feb 5, 2019
Kronhyx
suggested changes
Feb 5, 2019
| <div class="tab"> | ||
| {% set messages = collector.messages %} | ||
| {% set exceptionsCount = collector.exceptionsCount %} | ||
| <h3 class="tab-title">All<span class="badge {{ exceptionsCount ? exceptionsCount == messages|length ? 'status-error' : 'status-some-errors' }}">{{ messages|length }}</span></h3> |
There was a problem hiding this comment.
Taking advantage of the fact that you are refactoring why you do not use a strict comparison?
Suggested change
| <h3 class="tab-title">All<span class="badge {{ exceptionsCount ? exceptionsCount == messages|length ? 'status-error' : 'status-some-errors' }}">{{ messages|length }}</span></h3> | |
| <h3 class="tab-title">All<span class="badge {{ exceptionsCount ? exceptionsCount === messages|length ? 'status-error' : 'status-some-errors' }}">{{ messages|length }}</span></h3> |
There was a problem hiding this comment.
Twig doesn't have a === operator.
There was a problem hiding this comment.
But it has:
exceptionsCount is same as (messages|length)
No sure it worth using it here anyway.
Kronhyx
approved these changes
Feb 6, 2019
xabbuh
approved these changes
Feb 6, 2019
|
Thank you @ottaviano. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Fix DataCollector template | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ It's for adding a closing DIV tag on L96 (+ re-indent the HTML code) Commits ------- 146ae74 [Messenger] Fix DataCollector template
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's for adding a closing DIV tag on L96 (+ re-indent the HTML code)