[Workflow] Graphviz dumper escape not always a string #30102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierstoval
reviewed
Feb 7, 2019
|
I have update the base branch as it should target 4.2. Could you rebase please? |
lyrixx
requested changes
Feb 7, 2019
eb991e4 to
757b784
Compare
757b784 to
7b957ce
Compare
7b957ce to
0613f7d
Compare
lyrixx
approved these changes
Feb 7, 2019
0613f7d to
1b17192
Compare
|
Good catch, thanks Baptiste. |
lyrixx
added a commit
that referenced
this pull request
Feb 8, 2019
…beil) This PR was merged into the 4.2 branch. Discussion ---------- [Workflow] Graphviz dumper escape not always a string | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A The `escape` function takes a string as parameter but it can be a `bool` (see `findTransitions` method in same class). In this PR I allow any type in `escape` and does escaping only for `string`. Commits ------- 1b17192 escape function does not always take a string
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
escapefunction takes a string as parameter but it can be abool(seefindTransitionsmethod in same class). In this PR I allow any type inescapeand does escaping only forstring.