[Filesystem] Fix mirroring a directory into itself or in his child with realpath checks#30116
Merged
fabpot merged 2 commits intosymfony:masterfrom Mar 31, 2019
Merged
Conversation
12c07b8 to
55e8d21
Compare
nicolas-grekas
approved these changes
Feb 16, 2019
fabpot
reviewed
Feb 21, 2019
fe32a0a to
785dc05
Compare
f80d827 to
a3efb95
Compare
Author
|
Add handle for relative paths. CI build fails not related |
e174f37 to
5256eaa
Compare
Author
|
Added a bypass for symlink mirror tests on windows CI build fails not related |
Member
|
I think this PR does not qualify for being a bug fix but rather as a new feature. |
Author
|
Hi @fabpot , did you really think this PR should be qualify as a new feature ? Since the behavior of Indeed, adding absolute path management to |
Member
|
I still think this is a new feature as the use case itself was not supported at all. |
Author
|
Ok So I'll rebase this branch on master and change de PR. |
5256eaa to
dd2d409
Compare
…path name is equal to the target path Added a new test what is called testMirrorAvoidCopyingTargetDirectoryIfInSourceDirectory Adjustments to comply with the Symfony Code Standards
dd2d409 to
b312b7c
Compare
b312b7c to
8011f49
Compare
Author
|
@fabpot as you asked for, I've rebase this PR on master and qualify it as a new feature. |
fabpot
approved these changes
Mar 31, 2019
Member
|
Thank you @XuruDragon. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2019
…in his child with realpath checks (Fleuv, XuruDragon) This PR was merged into the 4.3-dev branch. Discussion ---------- [Filesystem] Fix mirroring a directory into itself or in his child with realpath checks | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none / PR #29857 | License | MIT | Doc PR | n/a This this the continuity of #29857 by @Fleuv Fix a bug while trying to mirror a directory into itself or in a child Adding handle real path checks when mirroring. Commits ------- 8011f49 Handling relative/absolute path 59437a4 Skipping iterations in the mirror() method where the iterated file's path name is equal to the target path
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This this the continuity of #29857 by @Fleuv
Fix a bug while trying to mirror a directory into itself or in a child
Adding handle real path checks when mirroring.