use PropertyAccessorInterface instead of PropertyAccessor #30136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Feb 11, 2019
vudaltsov
approved these changes
Feb 11, 2019
OskarStark
approved these changes
Feb 11, 2019
chalasr
approved these changes
Feb 11, 2019
ogizanagi
approved these changes
Feb 12, 2019
fabpot
approved these changes
Feb 12, 2019
|
I don't know how you guys usually handle this, but since the change is very small and probably has no negative impact, it could make sense. Let me know if i should open PR's for other branches as well. |
|
Thank you @nick-zh. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2019
…(nick-zh) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #30136). Discussion ---------- use PropertyAccessorInterface instead of PropertyAccessor [Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30133 (partially) | License | MIT | Doc PR | none Commits ------- 3e3ca9d use PropertyAccessorInterface instead of PropertyAccessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor