Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation] Do not set a Transfer-Encoding header of chunked for streaming responses #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 2 commits into from
Jan 2, 2012
Merged

[HttpFoundation] Do not set a Transfer-Encoding header of chunked for streaming responses #3017

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83c23ca
[streaming] Do not set a Transfer-Encoding header of chunked
igorw Jan 2, 2012
7ae9348
[streaming] Document and test that Transfer-Encoding is absent
igorw Jan 2, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[streaming] Do not set a Transfer-Encoding header of chunked 
Apache expects the response to already be in chunked format in that case,
which causes it to not deliver the streamed body.

If no Content-Length is set on the response, web servers will automatically
switch to chunked Transfer-Encoding, and handle the chunking for you.

Nginx does not share the issue that apache has, but will add the Content-
Length header too.
  • Loading branch information
@igorw
igorw committed Jan 2, 2012
commit 83c23ca0bea1b10224266fcf7ec58cc2fa52b94a
1 change: 0 additions & 1 deletion src/Symfony/Component/HttpFoundation/StreamedResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ public function prepare(Request $request)
{
if ('1.0' != $request->server->get('SERVER_PROTOCOL')) {
$this->setProtocolVersion('1.1');
$this->headers->set('Transfer-Encoding', 'chunked');
}

$this->headers->set('Cache-Control', 'no-cache');
Expand Down
1 change: 0 additions & 1 deletion tests/Symfony/Tests/Component/HttpFoundation/StreamedResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public function testPrepareWith11Protocol()
$response->prepare($request);

$this->assertEquals('1.1', $response->getProtocolVersion());
$this->assertEquals('chunked', $response->headers->get('Transfer-Encoding'));
$this->assertEquals('no-cache, private', $response->headers->get('Cache-Control'));
Copy link
Copy Markdown
Contributor

@schmittjoh schmittjoh Jan 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a negative test to avoid regressions and document why it's necessary, i.e. assertNotEquals(...)?

Copy link
Copy Markdown
Contributor Author

@igorw igorw Jan 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}

Expand Down