[Serializer] Fix denormalizing nested arrays as object values #30258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcfedr
commented
Feb 15, 2019
| @@ -52,6 +52,13 @@ public function denormalize($data, $class, $format = null, array $context = []) | |||
| $class = substr($class, 0, -2); | |||
|
|
|||
| $builtinType = isset($context['key_type']) ? $context['key_type']->getBuiltinType() : null; | |||
|
|
|||
| // Fix a collection that contains the only one element | |||
| // This is special to xml format only | |||
There was a problem hiding this comment.
This fix was in ObjectNormalizer, I think it makes more sense here, and now with the recursive types its harder to fit into ObjectNormalizer.
784b9f0 to
9c93527
Compare
fa2065a to
f42b39e
Compare
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
f42b39e to
b87b268
Compare
|
@nicolas-grekas Resolved all the comments, also rebased on 4.3 |
b87b268 to
820c052
Compare
820c052 to
952527d
Compare
|
@mcfedr I think we lost track of this PR, and the code changed now, so that there is a conflict to resolve. Could you please rebase this PR on 4.4? |
|
Closing because this stalled, but more importantly because this might have been fixed in #32832 already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ObjectNormalizer loses type information for nested arrays in its properties, resulting in failed denormalization
Basically if i have this property
The ObjectNormalizer just sees this as a 'array' type and injects the raw array, rather than passing it back to the Serializer with class
Child[][]