-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] add option to render NumberType as type="number" #30267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 16, 2019
•
edited
Loading
edited
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #8106 |
License | MIT |
Doc PR | symfony/symfony-docs#10997 |
This was referenced Feb 16, 2019
ro0NL
reviewed
Feb 16, 2019
nicolas-grekas
approved these changes
Feb 16, 2019
src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap3LayoutTest.php
Show resolved
Hide resolved
vudaltsov
approved these changes
Feb 19, 2019
...Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Feb 21, 2019
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
…" (xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [Form] add option to render NumberType as type="number" | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8106 | License | MIT | Doc PR | symfony/symfony-docs#10997 Commits ------- 42e8f5e add option to render NumberType as type="number"
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 3, 2019
This PR was merged into the master branch. Discussion ---------- [Form] document the NumberType html5 option see symfony/symfony#30267 Commits ------- bc5ac28 document the NumberType html5 option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.