[VarDumper] add link to source next to class names #30301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca4cb48 to
ffc52fb
Compare
stof
reviewed
Feb 19, 2019
9731815 to
bcb29a2
Compare
bcb29a2 to
5fcd6b1
Compare
|
Now green with greater BC. |
fabpot
approved these changes
Feb 21, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
…colas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] add link to source next to class names | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR adds a `^` next to language identifiers (class and callback names) both on the Web and on the CLI. Clicking it opens the IDE to the target source code: Eg in the profiler:  And in the CLI:  Commits ------- 5fcd6b1 [VarDumper] add link to source next to class names
|
@nicolas-grekas seems nested objects are not linked :( perhaps due the max. depth setting..
the nested |
|
No hint why sorry, would need to be investigated. |
Merged
fabpot
added a commit
that referenced
this pull request
Jun 6, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [HttpKernel] fix link to source generation | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31833 | License | MIT | Doc PR | - Introduced in #30301 Commits ------- 4a4b62b [HttpKernel] fix link to source generation
fabpot
added a commit
that referenced
this pull request
Sep 10, 2023
…n (derrabus) This PR was merged into the 6.4 branch. Discussion ---------- [DebugBundle] Remove obsolete VarDumper feature detection | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This PR removes detection for features introduced with #30301 (Symfony 4.3) and #27261 (Symfony 4.2). Commits ------- 9f9747c [DebugBundle] Remove obsolete VarDumper feature detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
^next to language identifiers (class and callback names) both on the Web and on the CLI. Clicking it opens the IDE to the target source code:Eg in the profiler:
And in the CLI:
