Additional addons for the ghost #30326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Feb 21, 2019
javiereguiluz
requested changes
Feb 21, 2019
There was a problem hiding this comment.
I'd like to ask to change the GHOST_PLUS symbol.
Do you know the Red Cross organization? Its symbol is the same you are proposing here for the "plus symbol". However, this symbol is so offensive to hundreds of millions of people in the world, that they changed it and use another one in lots of countries.
|
I think this "political correctness" thing is really getting out of hand. I mean it's a PLUS sign. A PLUS sign. |
|
I also think that the plus sign is ok. |
nicolas-grekas
approved these changes
Feb 21, 2019
xabbuh
approved these changes
Feb 21, 2019
|
Thank you @przemyslaw-bogusz. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- Additional addons for the ghost | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Following #30236 I've prepared two additional addons for the ghost. The first one will display a plus on February 29, to indicate it's a leap year.  The second one will display a gift on October 18, to indicate it's Symfony's birthday.  I would just like to point out that the addons are purely for fun, to amuse every hardcoding Symfony developer and offer a chance to smile on these few selected occasions. Commits ------- 51ed942 Additional addons for the ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #30236 I've prepared two additional addons for the ghost.
The first one will display a plus on February 29, to indicate it's a leap year.
The second one will display a gift on October 18, to indicate it's Symfony's birthday.
I would just like to point out that the addons are purely for fun, to amuse every hardcoding Symfony developer and offer a chance to smile on these few selected occasions.