Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] fix lowest supported Routing component version #30330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2019
Merged

[FrameworkBundle] fix lowest supported Routing component version #30330

merged 1 commit into from
Feb 22, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 21, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the next milestone Feb 21, 2019
@xabbuh xabbuh marked this pull request as ready for review February 21, 2019 12:26
@xabbuh
Copy link
Member Author

xabbuh commented Feb 21, 2019

I do not know though why the deps=low job didn't already fail in #30249 with the same error

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 715cf8d into symfony:master Feb 22, 2019
nicolas-grekas added a commit that referenced this pull request Feb 22, 2019
@nicolas-grekas
minor #30330 [FrameworkBundle] fix lowest supported Routing component…
f7f31b2 
… version (xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] fix lowest supported Routing component version

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

715cf8d fix lowest supported Routing component version
@xabbuh xabbuh deleted the pr-30249 branch February 22, 2019 09:44
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot