[Messenger] Added transport agnostic exception#30375
Conversation
src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpSender.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpSender.php
Outdated
Show resolved
Hide resolved
|
Should it also be added here: Didn't check what exception can occur here but I guess it should be consistent. |
|
I added a catch block whenever the I did not alter this throw because it's not transport-related. Although this one is related to transport, I choose to not trow a |
|
Can you rebase your pull request on current master? You merged master and it makes the PR non-mergeable. thank you. |
… could not send a message
…w new TransportException
|
My bad, here it is :) |
|
I checked tests errors, it's Component/Debug and Bundle/FrameworkBundle, which are failing on upstream/master too |
|
Thank you @lolmx. |
…vnk, lolmx) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Added transport agnostic exception | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30346 | License | MIT | Doc PR | TODO As described in #30346, client code shouldn't care about which transport is currently used by the message bus. This pr adds a new generic exception that is thrown by the `AmqpSender` if the message couldn't be delivered. Commits ------- 7d6a3fa Updated changelog to document changes in AmqpReceiver 62a08ee Updated exception message in AmqpSender, updated AmqpReceiver to throw new TransportException b2b0640 Chain new exception with previous one 06c8404 forgot one backslash, my bad 93c1001 [Messenger] Added new TransportException which is thrown if transport could not send a message
As described in #30346, client code shouldn't care about which transport is currently used by the message bus. This pr adds a new generic exception that is thrown by the
AmqpSenderif the message couldn't be delivered.