[FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null #30390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would also need to update the docblock of the |
src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php
Outdated
Show resolved
Hide resolved
606729a to
6471c00
Compare
|
This should be merged in 3.4 if we consider it as a bug fix. |
|
After thinking about it a bit more, I would rather merge it in master and add a note in the changelogs about the change. |
|
@eborges78 Can you rebase on current master instead of merging? Merge commits forbids us from merging the PR. Thank you. |
b6aa261 to
b921200
Compare
nicolas-grekas
approved these changes
Mar 4, 2019
xabbuh
approved these changes
Mar 4, 2019
fabpot
approved these changes
Mar 4, 2019
…g instead of null
|
Thank you @eborges78. |
fabpot
added a commit
that referenced
this pull request
Mar 4, 2019
… an empty string instead of null (Emmanuel BORGES) This PR was squashed before being merged into the 4.3-dev branch (closes #30390). Discussion ---------- [FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30306 | License | MIT Fix #30306 : Controller::generateUrl() must be of the type string, null returned Commits ------- c5b1247 [FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null
Merged
AntoineRoue
added a commit
to AntoineRoue/symfony-docs
that referenced
this pull request
Apr 6, 2021
Since symfony/symfony#30390, the documentation did not change.
AntoineRoue
added a commit
to AntoineRoue/symfony-docs
that referenced
this pull request
Apr 6, 2021
This value was not changed with symfony/symfony#30390
wouterj
pushed a commit
to AntoineRoue/symfony-docs
that referenced
this pull request
Apr 7, 2021
This value was not changed with symfony/symfony#30390
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 7, 2021
This PR was submitted for the 5.2 branch but it was merged into the 4.4 branch instead. Discussion ---------- Update framework.router.strict_requirements This value was not changed with symfony/symfony#30390 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `5.x` for features of unreleased versions). --> Commits ------- 90e6580 Update framework.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30306 : Controller::generateUrl() must be of the type string, null returned