[Form] group_by as callback returns array #30429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antonch1989
commented
Mar 3, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #30315 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
IIRC the form uses the choice value (in the view) to determine which option was selected, if multiple options share the same value it's no longer possible to safely determine which option (in which group) was selected, and the first matching option is selected. I might be wrong here, but you can verify (without to much hassle) if this works as expected by running an actual form in the web browser, and checking if the correct choice is marked as selected. Thanks for working on this 👍 |
|
@sstok correct, there is no way to determine which exact choice was picked |
8b422db to
4a31587
Compare
HeahDude
approved these changes
Apr 7, 2019
4a31587 to
4c04601
Compare
|
Thank you @antonch1989. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #30429). Discussion ---------- [Form] group_by as callback returns array | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30315 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 4c04601 [Form] group_by as callback returns array
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 3, 2019
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #11516). Discussion ---------- remove invalid array type This is not true before Symfony 4.3 (spotted while looking into how to document symfony/symfony#30429). Commits ------- 4be9672 remove invalid array type
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.