-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Profiler] Render the performance graph with SVG #30450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
fabpot
reviewed
Mar 5, 2019
stof
requested changes
Mar 5, 2019
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.css.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.css.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.js.twig
Outdated
Show resolved
Hide resolved
staabm
reviewed
Mar 6, 2019
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.css.twig
Show resolved
Hide resolved
stof
reviewed
Mar 6, 2019
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
Outdated
Show resolved
Hide resolved
stof
reviewed
Mar 8, 2019
Status: Needs Review |
chalasr
approved these changes
Mar 16, 2019
fabpot
approved these changes
Mar 16, 2019
Thank you @Tom32i. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #30450). Discussion ---------- [Profiler] Render the performance graph with SVG | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Part 1, 3 and 4 of #27262 | License | MIT | Doc PR | n/a Following a suggestion by @ogizanagi in #27262, Here's a proposal to render the Request Graph, from the performance profiler panel, with SVG instead of canvas. Some benefits of the SVG format: - The text labels are searchable and can be selected. - It renders well on high DPI monitors. - [Colors and text styles](#27262 (comment)) can be defined with CSS just like the rest of the page. In addition, SVG allow us to consider (and easily implement) interactives features such as: - Zoom in and time navigation (thanks to the viewport). - Highlight hovered line (or other DOM related events). Preview:  Filtered events example:  ### Progress : - [x] Render request events in SVG - [x] Show labels with duration and memory - [x] Show specific markers at start / end of lines - [x] Re-render graph when window resize - [x] Re-render graph when threshold change. - [x] Generate graph legend with only existing categories (part 1. of #27262 ) - [x] Show sub-request area with hatched pattern - [x] Allow to hide categories by clicking them on the legend (part 3. of #27262 ) - [x] Handle text overflow on long labels. - [x] Ensure JS code is compatible with all supported browsers (used [classes](https://caniuse.com/#feat=es6-class) and [arrow functions](https://caniuse.com/#feat=arrow-functions). - ~Add left-padding to sub-request graph?~ Commits ------- a69a718 [Profiler] Render the performance graph with SVG
Any chance to get this element as a standalone component, so we can re-use it in other web-frontends? |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Profiler] Fix graph text color | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - #30450 introduces bad text color for graph items in the profiler, specially in dark theme mode. ### before/after   There is a small change for default theme ### before/after   <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 44d9fbe Fix graph text color
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a suggestion by @ogizanagi in #27262,
Here's a proposal to render the Request Graph, from the performance profiler panel, with SVG instead of canvas.
Some benefits of the SVG format:
In addition, SVG allow us to consider (and easily implement) interactives features such as:
Preview:
Filtered events example:
Progress :
Add left-padding to sub-request graph?