[DI] replace "nullable" env processor by improving the "default" one#30504
Merged
fabpot merged 1 commit intosymfony:masterfrom Mar 10, 2019
Merged
[DI] replace "nullable" env processor by improving the "default" one#30504fabpot merged 1 commit intosymfony:masterfrom
fabpot merged 1 commit intosymfony:masterfrom
Conversation
jderusse
approved these changes
Mar 9, 2019
22823d2 to
d6a1871
Compare
Contributor
|
But it was my 1st PR! 😥 (French contributors will remind "mais t'avais dit qu'on ferait des knacki!") More seriously, that's a good idea 🙂 thank you @nicolas-grekas ! |
ro0NL
approved these changes
Mar 10, 2019
ogizanagi
approved these changes
Mar 10, 2019
Contributor
ogizanagi
left a comment
There was a problem hiding this comment.
Great. I like this one much more :)
d6a1871 to
c50aad2
Compare
Member
Author
|
@jderusse @bpolaszek would you mind sending a doc PR please? (see #10722) |
Member
|
done in symfony/symfony-docs#11127 |
fabpot
approved these changes
Mar 10, 2019
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 10, 2019
… "default" one (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [DI] replace "nullable" env processor by improving the "default" one | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Neither `nullable` nor `default` are released yet. I propose to replace the `nullable` processor (see #29767) with an improved `default` one (from #28976). `%env(default::FOO)%` now defaults to `null` when the env var doesn't exist or compares to false". ping @jderusse @bpolaszek Commits ------- c50aad2 [DI] replace "nullable" env processor by improving the "default" one
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 11, 2019
…sse) This PR was merged into the master branch. Discussion ---------- Document Default env processor with null fallback Document the fallback to `null` PR: symfony/symfony#30504 Commits ------- 309bd58 Document Default env processor with null fallback
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither
nullablenordefaultare released yet.I propose to replace the
nullableprocessor (see #29767) with an improveddefaultone (from #28976).%env(default::FOO)%now defaults tonullwhen the env var doesn't exist or compares to false".ping @jderusse @bpolaszek