[Routing] Exposed "utf8" option, defaults "locale" and "format" in configuration #30508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c97a98d to
9c45619
Compare
nicolas-grekas
previously approved these changes
Mar 10, 2019
|
I've just added support for annotations too :). Doc is coming. |
|
Why is it useful to expose |
|
Well, I was not sure, I did it by consistency. I felt like it was hidden and deserved to shine too :), but no hard feeling, if there is no real use case for it let's just keep utf8 which should increase DX (see related doc PR). |
|
I would remove it, that's an internal settings that does not need to be exposed. |
|
Done, I exposed the defaults instead, WDYT? Status: needs review |
fabpot
reviewed
Mar 17, 2019
|
@HeahDude Can you have a look at the broken tests? |
nicolas-grekas
approved these changes
Mar 20, 2019
fabpot
approved these changes
Mar 20, 2019
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Mar 20, 2019
… "format" in configuration (Jules Pietri) This PR was merged into the 4.3-dev branch. Discussion ---------- [Routing] Exposed "utf8" option, defaults "locale" and "format" in configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | symfony/symfony-docs#11126 A sibling to #30501, everything is in the title :). Commits ------- 2911490 [Routing] Exposed "utf8" option, defaults "locale" and "format" in configuration
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 25, 2019
…le" and "format" (Jules Pietri, HeahDude) This PR was merged into the master branch. Discussion ---------- [Routing][DX] Exposed "utf8" options, and defaults "locale" and "format" Documentation for symfony/symfony#30508 Commits ------- f9e2eaa fixup f1eae44 added doc for defaults 06a71a9 [Routing][DX] Exposed "compiler_class" and "utf8" options
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sibling to #30501, everything is in the title :).