Codestin Search App

GaryPEGEOT · 2019-03-13T16:37:11Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR	TODO

Add a new MockClient usable for test purpose:

/** @var ResponseInterface $response */
$response = $this->createMock(ResponseInterface::class);
$client = new MockClient();

// Add one or more predefined responses
$client->addResponse($response);

$client->request('GET', '/whatever', ['base_uri' => 'http://example.org']);

WDYT?

dunglas · 2019-03-14T07:21:07Z

Maybe could we also add a helper to create mock responses? Especially, implementing getInfo() requires some care (this method must return some mandatory values), and this could probably be automated. What I've in mind is something like:

new MockResponse(/* all args are optional */
    'content',
    200,
    ['X-Foo' => 'custom header, mandatory headers will be automatically populated'],
    ['x-info' => ['custom info, mandatory keys, including raw_headers will be automatically populated']
);

GaryPEGEOT · 2019-03-14T16:42:29Z

@dunglas just added the MockResponse, feedback welcome :)

dunglas · 2019-03-14T16:43:37Z

It looks great!

nicolas-grekas

1st round :)

src/Symfony/Component/HttpClient/MockClient.php

stof · 2019-03-18T13:29:09Z

src/Symfony/Component/HttpClient/CHANGELOG.md

 -----

 * added the component
+ * added a mock client


no need to add this in the changelog, as there is no component at all in previous version, so added the component describes the changes already.

stof · 2019-03-18T13:30:13Z

src/Symfony/Component/HttpClient/MockClient.php

+    }
+
+    /**
+     * Clear all predefined responses.


stof · 2019-03-18T13:36:00Z

src/Symfony/Component/HttpClient/Response/MockResponse.php

+{
+    use ResponseTrait;
+
+    protected const DEFAULT_INFO = [


should be private rather than protected IMO, following our convention of not using protected without having a clear use case for inheritance.

and change the access to self::, as using static:: to access a private thing is broken.

nicolas-grekas · 2019-03-19T16:07:43Z

A big thank you for starting this, I submitted another complete implementation in #30604.

[HttpClient] Add a mock client

651e77d

carsonbot added Status: Needs Review Feature labels Mar 13, 2019

nicolas-grekas added this to the next milestone Mar 13, 2019

nicolas-grekas mentioned this pull request Mar 13, 2019

[HttpClient] Next steps #30502

Closed

18 tasks

GaryPEGEOT added 4 commits March 13, 2019 22:16

Simplify usage

d0fec53

Test when things goes wrong

a23d93b

Fix stream behavior, add error test cases.

2cd81de

Remove useless method

206d786

add a mock response

72aa094

nicolas-grekas added the HttpClient label Mar 16, 2019

nicolas-grekas reviewed Mar 16, 2019

View reviewed changes

1st round fixes

b3d4a28

nicolas-grekas reviewed Mar 17, 2019

View reviewed changes

src/Symfony/Component/HttpClient/MockClient.php Show resolved Hide resolved

Remove useless try

e2c69c2

stof reviewed Mar 18, 2019

View reviewed changes

GaryPEGEOT added 2 commits March 18, 2019 18:42

Typo fix

9210c1d

Switch to private

5985f9c

nicolas-grekas closed this Mar 19, 2019

nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

Uh oh!

Comments

Conversation

GaryPEGEOT commented Mar 13, 2019

Uh oh!

dunglas commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaryPEGEOT commented Mar 14, 2019

Uh oh!

dunglas commented Mar 14, 2019

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stof Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

stof Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

stof Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

stof Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

GaryPEGEOT Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Mar 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dunglas commented Mar 14, 2019 •

edited

Loading