[HttpClient] Allow to pass user/pw as an array #30556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Mar 13, 2019
|
This one needs to be rebased :) |
fabpot
approved these changes
Mar 14, 2019
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] Allow to pass user/pw as an array | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes<!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a Makes the API a bit more "PHPish". Commits ------- 8d5096a [HttpClient] Allow to pass user/pw as an array
|
Do we really want to allow two different ways of doing the same thing? Maybe allowing only the use of arrays instead of strings could be enough? |
|
I wouldn't mind having only the array way. Makes sense to me. WDYT @dunglas @nicolas-grekas? |
|
Being allowed to pass a string doesn't hurt IMO (as it's a standard), but if we have to choose only one I'll go for the array way too. |
|
The string is the only thing that the standard describes. The array is only sugar, and leaks actually (you can't use a I'm for keeping the string of there should be only one. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the API a bit more "PHPish".