Using AMQP auto-setup in all cases, not just in debug#30579
Merged
fabpot merged 1 commit intosymfony:masterfrom Mar 17, 2019
Merged
Using AMQP auto-setup in all cases, not just in debug#30579fabpot merged 1 commit intosymfony:masterfrom
fabpot merged 1 commit intosymfony:masterfrom
Conversation
lyrixx
approved these changes
Mar 15, 2019
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/ConnectionTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Mar 16, 2019
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
(with minor typo)
another step forward for Messenger :)
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/ConnectionTest.php
Outdated
Show resolved
Hide resolved
069ab5f to
503c209
Compare
Contributor
Author
|
Ready now! |
sroze
approved these changes
Mar 17, 2019
Contributor
|
Good point 👍 |
fabpot
approved these changes
Mar 17, 2019
Member
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2019
…(weaverryan) This PR was merged into the 4.3-dev branch. Discussion ---------- Using AMQP auto-setup in all cases, not just in debug | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes and no | New feature? | no | BC breaks? | yes | Deprecations? | no-> | Tests pass? | yes | Fixed tickets | Related to #29476 | License | MIT | Doc PR | TODO Currently AMQP does auto-setup of queues/exchanges in dev-mode only. That's a problem for 2 reasons: 1) Behavior in prod is drastically different... and actually... there's not currently a way I know of (easily) to set things up on prod. 2) One of the properties of AMQP is that you typically DO want things to be set up at runtime, as you need them - you usually *do* want auto-setup. This changes the behavior to auto-setup true always. Commits ------- 503c209 Using AMQP auto-setup in all cases, not just in debug
Merged
Contributor
|
It does setup on EVERY consumed message, is it?. It, for sure, decreases consumption performance. That might also put some undesired load on RabbitMQ itself for it does four actions instead of one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently AMQP does auto-setup of queues/exchanges in dev-mode only. That's a problem for 2 reasons:
Behavior in prod is drastically different... and actually... there's not currently a way I know of (easily) to set things up on prod.
One of the properties of AMQP is that you typically DO want things to be set up at runtime, as you need them - you usually do want auto-setup.
This changes the behavior to auto-setup true always.