[Cache] added DSN support for rediss in AbstractAdapter and RedisTrait #30605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 19, 2019
| @@ -80,8 +80,8 @@ private function init($redisClient, $namespace, $defaultLifetime, ?MarshallerInt | |||
| */ | |||
| public static function createConnection($dsn, array $options = []) | |||
| { | |||
| if (0 !== strpos($dsn, 'redis:')) { | |||
| throw new InvalidArgumentException(sprintf('Invalid Redis DSN: %s does not start with "redis:".', $dsn)); | |||
| if (0 !== strpos($dsn, 'redis:') && 0 !== strpos($dsn, 'rediss:')) { | |||
There was a problem hiding this comment.
you also need to update the regex of the preg_replace_callback below
There was a problem hiding this comment.
OK, @stof , I added tests and modified regexp.
nicolas-grekas
approved these changes
Mar 20, 2019
fabpot
approved these changes
Mar 20, 2019
|
Thank you @alex-vasilchenko-md. |
fabpot
added a commit
that referenced
this pull request
Mar 20, 2019
…r and RedisTrait (alex-vasilchenko-md) This PR was squashed before being merged into the 4.3-dev branch (closes #30605). Discussion ---------- [Cache] added DSN support for rediss in AbstractAdapter and RedisTrait | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30573 | License | MIT A fix for this issue: #30573 Support for "rediss:" in DSN added. Commits ------- 7e2852d [Cache] added DSN support for rediss in AbstractAdapter and RedisTrait
|
AFAICT, this will still treat it the same than |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for this issue: #30573
Support for "rediss:" in DSN added.