-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] allow brackets in the optional query string #30606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The name |
@eborges78 Can you rebase to get rid of the merge commit? |
2940c3d
to
4fc4015
Compare
Fixed. |
3bc4d1a
to
5fe210c
Compare
Do we really need an option for that? Why would you not allow it? |
I did not want to alter the existing behavior of the UrlValidator. |
I would vote for having this by default with no options. WDYT @symfony/deciders? |
I agree with Fabien. According to RFC 3986 the following line is the regular expression for breaking-down a well-formed URI reference into its components:
This is the query string part -> |
@fabpot @javiereguiluz Thank you for your feedback. so I removed the option and allowed brackets by default |
Thank you @eborges78. |
…g (Emmanuel BORGES) This PR was squashed before being merged into the 4.3-dev branch (closes #30606). Discussion ---------- [Validator] allow brackets in the optional query string | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30603 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Add the `allowBrackets` option from the Url constraint to allow brackets in the optional query string. Commits ------- 40dc4c8 [Validator] allow brackets in the optional query string
Add the
allowBrackets
option from the Url constraint to allow brackets in the optional query string.