Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PHPUnitBridge] fix SYMFONY_DEPRECATIONS_HELPER env is empty in bootstrap #30639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eborges78
Copy link

@eborges78 eborges78 commented Mar 22, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30411
License MIT

The value of SYMFONY_DEPRECATIONS_HELPER in .env.test was ignored.
This fix load the .env.test file when bootstrap.php is loaded by a run of phpunit.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Mar 25, 2019
@nicolas-grekas
Copy link
Member

Why is this needed? Shouldn't #30490 have resolved the issue?
I'd rather avoid loading the autoloader using unexpected logic.

@eborges78
Copy link
Author

You're right, it's fixed in 4.3! so I close this PR.

@eborges78 eborges78 closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants