[Finder] Get filename without extension#30664
Merged
fabpot merged 1 commit intosymfony:masterfrom Mar 27, 2019
Merged
Conversation
OskarStark
reviewed
Mar 24, 2019
Contributor
OskarStark
left a comment
There was a problem hiding this comment.
Thank you for this contribution, please fix the table in the PR header, because this is no bugfix, but a feature.
137f287 to
821e55a
Compare
Member
|
Thank you @antonch1989. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #30664). Discussion ---------- [Finder] Get filename without extension | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30655 | License | MIT | Doc PR | Commits ------- 821e55a [Finder] Get filename without extension
Contributor
|
Thank you for this contribution, can you please add some documentation for this new feature? |
Member
|
I find this method confusing. It's called getFilenameWithoutExtension('foo.html'); // foo
getFilenameWithoutExtension('foo.html.twig'); // foo.html
getFilenameWithoutExtension('foo.tar.gz'); // foo.tarI expected |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.