Add optional parameter prefetching for AMQP connection#30671
Add optional parameter prefetching for AMQP connection#30671sroze merged 1 commit intosymfony:masterfrom
prefetching for AMQP connection#30671Conversation
|
The diff seems a mess. Are you sure that your feature branch is based on master ? |
…etup` (dmaicher) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] rename `auto-setup` amqp option into `auto_setup` | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See #30671 (comment) Commits ------- 6263e48 [Messenger] rename `auto-setup` amqp option into `auto_setup`
fabpot
left a comment
There was a problem hiding this comment.
Left a minor comment. Also, can you squash the commits?
src/Symfony/Component/Messenger/Transport/AmqpExt/Connection.php
Outdated
Show resolved
Hide resolved
…setup channel prefetch count Co-Authored-By: f2r <[email protected]>
|
Thank you @f2r. |
…on (fbouchery) This PR was merged into the 4.3-dev branch. Discussion ---------- Add optional parameter `prefetching` for AMQP connection Add prefetching connection parameter to setup channel prefetch count. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When setting up AMQP transport connection, it can be interesting to configure prefetching on a channel, which is not currently possible. Commits ------- 47777ee Add optional parameter `prefetching` in connection configuration, to setup channel prefetch count
|
I'm pretty sure this prefetch option is useless. Symfony messenger uses amqp
@f2r have you seen any impact using this option? |
|
IMHO, we should revert this PR since it does not work and can be misleading |
|
If we think this should be reverted, let's create a PR. |
I missed @Tobion's comment, sorry! It was part of a larger submission that brought @weaverryan to make changes in Messenger (mainly, "retry" process) and so I removed it from my code. That was all that was left and it was linked to my proposal of using "basic.consume". |
|
Does someone wanna work on it? |
Work on what ? |
|
Reverting this PR |
|
see #39660 |
This PR was merged into the 5.3-dev branch. Discussion ---------- [Messenger] Deprecate option prefetch_count | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yesno | Tickets | - | License | MIT | Doc PR | - Revert #30671 Commits ------- 5b55097 Deprecate option prefetch_count
Add prefetching connection parameter to setup channel prefetch count.
When setting up AMQP transport connection, it can be interesting to configure prefetching on a channel, which is not currently possible.