[Serializer] Use object class resolver when extracting attributes #30711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Mar 27, 2019
c384f41 to
1d8b5af
Compare
|
Thank you @joelwurtz. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2019
…ributes (joelwurtz) This PR was squashed before being merged into the 4.2 branch (closes #30711). Discussion ---------- [Serializer] Use object class resolver when extracting attributes | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no (not sure) | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Current ObjectNormalizer was not using the object class resolver when extracting attributes, i found this when trying to refactor api platform normalizers and dealing with doctrine proxy objet having __initialize__ property not wanted cf api-platform/core#2579 I don't think this is BC break, but maybe some people using this object class resolver can get different behavior ? Commits ------- 1d8b5af [Serializer] Use object class resolver when extracting attributes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ObjectNormalizer was not using the object class resolver when extracting attributes, i found this when trying to refactor api platform normalizers and dealing with doctrine proxy objet having initialize property not wanted cf api-platform/core#2579
I don't think this is BC break, but maybe some people using this object class resolver can get different behavior ?