[HttpKernel] change $previous argument for HttpException to \Throwable#30729
[HttpKernel] change $previous argument for HttpException to \Throwable#30729fabpot merged 1 commit intosymfony:masterfrom sGy1980de:4.2
Conversation
|
Thanks, LGTM. Should target master as it's a new feature. |
|
@nicolas-grekas |
|
This never worked as you said, so it wasn't supported. Adding support for something that wasn't possible before is almost the definition of a new feature to me. |
|
So what's next? |
|
@sGy1980de I marked it as a bug because the issue description looked as a bug. But I could be wrong, so please don't think that it's definitive. |
|
Hey guys - what about the bug vs. feature discussion on this? Is it discussed internally or are all following @nicolas-grekas opinion and i should raise this with target master again? |
|
I tend to agree with @nicolas-grekas here. |
|
Thank you @sGy1980de. |
…on to \Throwable (sGy1980de) This PR was submitted for the 4.2 branch but it was squashed and merged into the 4.3-dev branch instead (closes #30729). Discussion ---------- [HttpKernel] change $previous argument for HttpException to \Throwable | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30728 | License | MIT This will fix #30728 with the suggested solution to change the signature of `HttpException` and all its descendants from `\Exception` to `\Throwable`. Commits ------- 15cb475 [HttpKernel] change $previous argument for HttpException to \Throwable
This PR was merged into the 4.3-dev branch. Discussion ---------- Fix some exception previous type hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a follow-up for #30729 Commits ------- f92efeb fixed some exception previous type hints
This will fix #30728 with the suggested solution to change the signature of
HttpExceptionand all its descendants from\Exceptionto\Throwable.