[Messenger] Adding MessageCountAwareInterface to get transport message count#30757
Merged
fabpot merged 1 commit intosymfony:masterfrom Apr 3, 2019
Merged
Conversation
This was referenced Mar 28, 2019
6759738 to
b3fe876
Compare
OskarStark
reviewed
Mar 29, 2019
src/Symfony/Component/Messenger/Transport/Receiver/MessageCountAwareReceiverInterface.php
Outdated
Show resolved
Hide resolved
Contributor
|
I don't think we should add it to the core without knowing the actually use-case tbh. |
dc21b88 to
adda867
Compare
Contributor
Author
Very fair. So, let me try to be more specific... even though I admit, I'm "planning ahead" a bit here. One easy thing to look at is Larave's Horizon, which takes advantage of the "size" of a queue for (A) displaying a health dashboard and (B) for automatically spinning up/down more/less workers for each transport, based on the size. Without this feature (which is pretty simple), creating something like that as a 3rd party bundle, for example, will not be possible. Rebased and comments addressed! |
b7a472b to
decd53f
Compare
Contributor
Author
|
@vincenttouzet could you check the Doctrine part of this PR out? There is an integration test, but would love your +1 technically for it. |
Contributor
vincenttouzet
left a comment
There was a problem hiding this comment.
Except the comment on the fetch / fetchColumn this looks good to me and very promising !
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
onEXHovia
reviewed
Apr 1, 2019
src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpTransport.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Apr 1, 2019
src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
Outdated
Show resolved
Hide resolved
7292b2b to
acddcae
Compare
nicolas-grekas
approved these changes
Apr 3, 2019
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
(it'd be nice updating the 1st commit message with the new name of the interface)
fabpot
approved these changes
Apr 3, 2019
acddcae to
fc5b0cf
Compare
Member
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2019
…ransport message count (weaverryan) This PR was squashed before being merged into the 4.3-dev branch (closes #30757). Discussion ---------- [Messenger] Adding MessageCountAwareInterface to get transport message count | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | symfony/symfony-docs#11236 This adds a new optional interface that receivers should implement to give an approximate number of the messages "waiting" to be handled. Why? Because, with this, you could design a system that dynamically adds/removes worker processes if a specific transport is getting slammed and needs help. Creating that system could be something we discuss for core later, but this at least makes it possible - and means it could be implemented by the user or in a bundle... which I might do if we don't get it in core ;). Commits ------- fc5b0cf [Messenger] Adding MessageCountAwareInterface to get transport message count
ro0NL
reviewed
Apr 4, 2019
|
|
||
| $sender->send($first = new Envelope(new DummyMessage('First'))); | ||
| $sender->send($second = new Envelope(new DummyMessage('Second'))); | ||
| $sender->send($second = new Envelope(new DummyMessage('Third'))); |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new optional interface that receivers should implement to give an approximate number of the messages "waiting" to be handled. Why? Because, with this, you could design a system that dynamically adds/removes worker processes if a specific transport is getting slammed and needs help. Creating that system could be something we discuss for core later, but this at least makes it possible - and means it could be implemented by the user or in a bundle... which I might do if we don't get it in core ;).