[3.4] [Validator] Add missing french validators translations #30945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhamon
commented
Apr 7, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
|
Very nice! We'd also include another new translation. See #30946. |
|
Thanks Javier! I've put the french translation for the compromised password constraint in @xabbuh's PR so that he can update the file accordingly :) |
lyrixx
approved these changes
Apr 7, 2019
fabpot
reviewed
Apr 7, 2019
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
xabbuh
previously requested changes
Apr 7, 2019
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Show resolved
Hide resolved
6f980d4 to
5cfd0d0
Compare
greg0ire
suggested changes
Apr 7, 2019
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
8d35900 to
0883342
Compare
0883342 to
331b601
Compare
|
I think it's good to go! |
fabpot
approved these changes
Apr 7, 2019
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2019
…ions (hhamon) This PR was merged into the 3.4 branch. Discussion ---------- [3.4] [Validator] Add missing french validators translations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 331b601 [3.4] [Validator] Add missing french validation translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.