Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] sync validator translations #30946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

[Validator] sync validator translations #30946

merged 1 commit into from
Apr 7, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 7, 2019 •
edited
Loading

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

#FOSSHackathons #EUFOSSA

@xabbuh xabbuh added this to the 3.4 milestone Apr 7, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Apr 7, 2019

ping @dbrumann @derrabus @mpdude @OskarStark

@javiereguiluz javiereguiluz mentioned this pull request Apr 7, 2019
Merged
@xabbuh xabbuh force-pushed the pr-27738-translations branch from 8b9b401 to e587245 Compare April 7, 2019 07:47
@hhamon
Copy link
Contributor

hhamon commented Apr 7, 2019 •
edited
Loading

French version:

Ce mot de passe a été révélé par une faille de sécurité et ne devrait plus être utilisé. Veuillez utiliser un autre mot de passe.

@lyrixx
Copy link
Member

lyrixx commented Apr 7, 2019

Why did you target Symfony 3.4? The valdator has been introduced in 4.3

@xabbuh
Copy link
Member Author

xabbuh commented Apr 7, 2019

@lyrixx To ease the maintainability of the translations we always add them on the lowest maintained branch. But in fact we already messed up ids between branches. I am trying to clean them up.

@xabbuh xabbuh force-pushed the pr-27738-translations branch 4 times, most recently from 1a30a0f to d2f3a28 Compare April 7, 2019 08:22
@xabbuh xabbuh marked this pull request as ready for review April 7, 2019 08:26
@xabbuh xabbuh changed the title [Validator] translate the not compromised constraint message [Validator] sync validator translations Apr 7, 2019
@xabbuh xabbuh force-pushed the pr-27738-translations branch from d2f3a28 to 83f675d Compare April 7, 2019 11:53
@fabpot
Copy link
Member

fabpot commented Apr 7, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 83f675d into symfony:3.4 Apr 7, 2019
fabpot added a commit that referenced this pull request Apr 7, 2019
@fabpot
minor #30946 [Validator] sync validator translations (xabbuh)
615cc10 
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] sync validator translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

#FOSSHackathons #EUFOSSA

Commits
-------

83f675d sync validator translations
@xabbuh xabbuh deleted the pr-27738-translations branch April 7, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@derrabus derrabus derrabus left review comments

@OskarStark OskarStark OskarStark requested changes

@jschaedl jschaedl jschaedl approved these changes

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
10 participants
@xabbuh @hhamon @lyrixx @fabpot @nicolas-grekas @OskarStark @derrabus @jschaedl @dbrumann @carsonbot