[Serializer] Add new normalizer: PropertyInfoNormalizer based on PropertyInfo / PropertyAccess components #30960
Conversation
|
|
||
| private $objectClassResolver; | ||
|
|
||
| public function __construct($instantiator, ObjectPropertyListExtractor $normalizerExtractor, PropertyListExtractorInterface $denormalizerExtractor, PropertyAccessorInterface $propertyAccessor, AdvancedNameConverterInterface $nameConverter = null, callable $objectClassReolver = null) |
There was a problem hiding this comment.
We should allow to pass the standard NameConverterInterface here (and pass the extra argument required for the advanced one).
| public function normalize($object, $format = null, array $context = []) | ||
| { | ||
| $properties = $this->normalizerExtractor->getProperties($object, $context); | ||
| $class = $this->objectClassResolver ? ($this->objectClassResolver)($object) : \get_class($object); |
There was a problem hiding this comment.
Shouldn’t we deal with Doctrine proxies here?
There was a problem hiding this comment.
That's what we do isn't it ?
Allowing an object class resolver will allow to inject a specific callback to handle this problem.
|
What is the status of this PR? @joelwurtz could you finish this or leave a comment to help others taking over this PR? |
|
This PR need the advancement of all points present in #30818 as it will use all interface / implementations make on those differents PR to create this new normalizer |
| $propertyName = $this->nameConverter ? $this->nameConverter->normalize($property, $class, $format, $context) : $property; | ||
| $value = $this->propertyAccessor->getValue($object, $property); | ||
|
|
||
| if (!is_scalar($value)) { |
There was a problem hiding this comment.
I'd add null !== $value && before to save some iterations, wdyt?
|
We've just moved away from |
This add the new Normalizer, as a Draft as we don't have all the building blocks actually, to show how we want to resolve things.
Will update this PR on the course of others advancement for #30818