[Serializer] Experimental for ObjectListExtractor#30963
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Apr 7, 2019
Merged
Conversation
stof
requested changes
Apr 7, 2019
src/Symfony/Component/Serializer/Extractor/ObjectPropertyListExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Extractor/ObjectPropertyListExtractorInterface.php
Outdated
Show resolved
Hide resolved
dunglas
approved these changes
Apr 7, 2019
Member
dunglas
left a comment
There was a problem hiding this comment.
When the typos will be fixed.
b6df430 to
b0cdf45
Compare
nicolas-grekas
approved these changes
Apr 7, 2019
Member
|
Thank you @joelwurtz. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2019
…lwurtz) This PR was merged into the 4.3-dev branch. Discussion ---------- [Serializer] Experimental for ObjectListExtractor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30904 | License | MIT | Doc PR | - Related to #30818 I want to mark this class as `@expiremental` until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3 Mark also `final` for the default implementation as we don't want that to be extendable and user should use composition over inheritance. Commits ------- b0cdf45 Set object list extractor as expiremental, and use final for default implementation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #30818
I want to mark this class as
@expirementaluntil we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3Mark also
finalfor the default implementation as we don't want that to be extendable and user should use composition over inheritance.