[WebProfiler] Fix Javascript error when using custom stopwatch categories #30973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Apr 7, 2019
stof
approved these changes
Apr 8, 2019
fabpot
approved these changes
Apr 8, 2019
|
Thank you @curry684. |
fabpot
added a commit
that referenced
this pull request
Apr 8, 2019
…atch categories (curry684) This PR was squashed before being merged into the 4.3-dev branch (closes #30973). Discussion ---------- [WebProfiler] Fix Javascript error when using custom stopwatch categories Fixes #30745 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30745 | License | MIT Made the getter do lazy creation so it can dynamically adapt to whatever it's given. Commits ------- e991472 [WebProfiler] Fix Javascript error when using custom stopwatch categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30745
Made the getter do lazy creation so it can dynamically adapt to whatever it's given.