Updated some translation files #31053
Conversation
|
Can you also provide the few missing translations in https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Resources/translations/validators.eu.xlf (English goes to id 93 while Basque only has them until id 85) ? |
Maybe @javiereguiluz? He's from Vitoria. |
I'm going to see what can I do... |
|
Yes, I understand some Basque. Translation looks correct to me, but we could ping our friend @ikerib who speaks Basque perfectly and contributed some translations in the past! Thanks. |
src/Symfony/Component/Validator/Resources/translations/validators.es.xlf
Outdated
Show resolved
Hide resolved
| <trans-unit id="92"> | ||
| <source>This value is not a valid timezone.</source> | ||
| <target>Este valor no es una zona horaria válida.</target> | ||
| </trans-unit> | ||
| <trans-unit id="93"> | ||
| <source>This password has been leaked in a data breach, it must not be used. Please use another password.</source> | ||
| <target>Esta contraseña ha sido desvelada por un fallo de seguridad y no debería volver a ser utilizada. Por favor utilice otra contraseña</target> |
There was a problem hiding this comment.
This message is very difficult to translate. I'd recommend an alternative translation to clearly explain that this is not a security problem of our own application:
Esta contraseña no se puede utilizar porque está incluida en un listado de contraseñas públicas obtenido gracias a fallos de seguridad de otros sitios y aplicaciones. Por favor utilice otra contraseña.
There was a problem hiding this comment.
Maybe french translation should be rewieved beacause I've translated it from this line
There was a problem hiding this comment.
The french translation is right btw.
There was a problem hiding this comment.
@Simperfit I'm not sure about that. First, "data breach" should be translated as violation de données instead of "faille de sécurité". Second, the way it's written could mean that the security problem is caused by the web site or application displaying the message.
There was a problem hiding this comment.
I understand what you mean, for me it does not mean that the current application showing the message is one who has been hacked / selled.
But It can be improved with what you proposed to have the same meaning in french.
smth like: "Ce mot de passe ne peut pas être utilisé car il fait partie d'une liste de mots de passe publics obtenus grâce aux fuites de données liée à d'autres sites et applications. Veuillez utiliser un autre mot de passe."
WDYT ? I make a PR ?
There was a problem hiding this comment.
It's super long ... but it describes the problem with absolute precision and I think most users can understand it. I wish we could find a more concise message while still explaining things well, but I think we can't.
|
@ikerib in f496ab6 you contributed the translations related to "validators" ... but in Symfony we have other translation files. In this PR, @cluster28 is translating the "security" file. So, we wonder if you have some time to double check these new translations and propose some fixes if needed. Thanks! |
|
Ahhhh I see. Ok, I’m on holidays now but I’ll do it as soon as possible ;-) |
…imperfit) This PR was squashed before being merged into the 3.4 branch (closes #31074). Discussion ---------- minor: the meaning of the data breach was not correct | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> It seems that the french translation was wrong as the phrasing suggested that the data breach came from the current application/website. Changing as discussed here: #31053 (comment) Commits ------- 97ac9ba minor: the meaning of the data breach was not correct
|
Why does this PR update |
|
@nicolas-grekas the title of the PR is misleading. We're updating two different languages in the same PR. |
|
Should we merge as is for now? |
…gs from php files (Stadly) This PR was squashed before being merged into the 3.4 branch (closes #31275). Discussion ---------- [Translator] Preserve default domain when extracting strings from php files | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Use default domain when extracting translation strings with `null` as domain. Commits ------- ca77d9a [Translator] Preserve default domain when extracting strings from php files
|
Thank you @cluster28. |
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #31053). Discussion ---------- Updated some translation files Basque translations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | # | License | MIT | Doc PR | symfony/symfony-docs <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 1d5aaf6 Updated some translation files
Basque translations