Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Show all option normalizers on debug:form command #31082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2019
Merged

[Form] Show all option normalizers on debug:form command #31082

merged 1 commit into from
Apr 15, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Apr 11, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT

Follow-up #30371

normalizers

@yceruto yceruto force-pushed the debug_form_option_normalizers branch 3 times, most recently from 713fdc6 to 90bc7f7 Compare April 11, 2019 22:38
@yceruto yceruto requested a review from xabbuh as a code owner April 11, 2019 22:38
@xabbuh xabbuh added this to the next milestone Apr 12, 2019
@OskarStark
Copy link
Contributor

A bit of topic but as you are on it... In the Allowed types section shouldn’t it be null without quotes? 🤔

@yceruto
Copy link
Member Author

yceruto commented Apr 12, 2019 •
edited
Loading

Hi @OskarStark, the output is consistent with its definition, we pass 'null' as allowed type:

symfony/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php

Line 43 in 572864b

$resolver->setAllowedTypes('query_builder', ['null', 'callable', 'Doctrine\ORM\QueryBuilder']);

@yceruto yceruto force-pushed the debug_form_option_normalizers branch from 90bc7f7 to f1d3bc0 Compare April 15, 2019 13:16
@yceruto
Copy link
Member Author

yceruto commented Apr 15, 2019 •
edited
Loading

Rebased and conflict fixed

@fabpot
Copy link
Member

fabpot commented Apr 15, 2019

Thank you @yceruto.

@fabpot fabpot merged commit f1d3bc0 into symfony:master Apr 15, 2019
fabpot added a commit that referenced this pull request Apr 15, 2019
@fabpot
feature #31082 [Form] Show all option normalizers on debug:form comma…
7cf96a4 
…nd (yceruto)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Form] Show all option normalizers on debug:form command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Follow-up #30371

![normalizers](https://user-images.githubusercontent.com/2028198/55996454-6667df80-5c85-11e9-94f6-9ee3988833f3.png)

Commits
-------

f1d3bc0 Show all option normalizers on debug:form command
@yceruto yceruto deleted the debug_form_option_normalizers branch April 15, 2019 22:09
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@yceruto @OskarStark @fabpot @xabbuh @nicolas-grekas @carsonbot