[PhpUnitBridge] ClockMock does not mock gmdate()#31093
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Apr 12, 2019
Merged
[PhpUnitBridge] ClockMock does not mock gmdate()#31093nicolas-grekas merged 1 commit intosymfony:masterfrom
nicolas-grekas merged 1 commit intosymfony:masterfrom
Conversation
4046438 to
3d5c6be
Compare
3d5c6be to
b34738b
Compare
nicolas-grekas
approved these changes
Apr 12, 2019
Member
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2019
…erfit) This PR was merged into the 4.3-dev branch. Discussion ---------- [PhpUnitBridge] ClockMock does not mock gmdate() | Q | A | ------------- | --- | Branch? | feature | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30393 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#11418 <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Adding the feature to mock gmdate directly in ClockMock. Commits ------- b34738b [PhpUnitBridge] ClockMock does not mock gmdate()
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the feature to mock gmdate directly in ClockMock.