Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Intl] Update the ICU data to 64.2 #31162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2019
Merged

[Intl] Update the ICU data to 64.2 #31162

merged 1 commit into from
Apr 21, 2019

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Apr 18, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes, including intl-data group
Fixed tickets -
License MIT
Doc PR -

It didn't take long for the ICU team to release a new version.

From their changelog, 64.2 provides bug fixes and:

  • Draft Unicode 12.1 data integration
  • Updated locale data imported from CLDR 35.1
  • Support for the new Japanese era "Reiwa" (令和).

@stof
Copy link
Member

stof commented Apr 18, 2019

based on the diff, the only relevant changes for this component are:

  • region name for MK is updated
  • locale names for mk_MK and sq_MK are updated (probably related to previous change)

Other ICU changes are not impacting the data we bundle.

@jakzal jakzal changed the title WIP: [Intl] Update the ICU data to 64.2 [Intl] Update the ICU data to 64.2 Apr 18, 2019
@fabpot
Copy link
Member

fabpot commented Apr 21, 2019

Thank you @jakzal.

@fabpot fabpot merged commit 9aa2349 into symfony:3.4 Apr 21, 2019
fabpot added a commit that referenced this pull request Apr 21, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] Update the ICU data to 64.2

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      |no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes, including intl-data group
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

It didn't take long for the ICU team to release a new version.

From their [changelog](http://site.icu-project.org/download/64#TOC-ICU4C-Download), 64.2 provides bug fixes and:

* Draft Unicode 12.1 data integration
* Updated locale data imported from CLDR 35.1
* Support for the new Japanese era "Reiwa" (令和).

Commits
-------

9aa2349 [Intl] Update the ICU data to 64.2
@jakzal jakzal deleted the icu-64.2 branch April 22, 2019 19:37
fabpot added a commit that referenced this pull request Apr 29, 2019
…country mapping (ro0NL)

This PR was squashed before being merged into the 4.3-dev branch (closes #31262).

Discussion
----------

[Intl] Update timezones to ICU 64.2 + compile zone to country mapping

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This PR compiles the zone to country mapping (and vice versa) from ICU data:
https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/windowsZones.txt

I've recompiled timezones on master due #31162, i should do it once more when it's merged upstream.

Having this data allows compatibility between PHP timezones and ICU;
- https://www.php.net/manual/en/intltimezone.getregion.php
- https://www.php.net/manual/en/class.datetimezone.php#datetimezone.constants.per-country

For the timezone validator in Symfony, this would be required to have a compatible "regions" option, once it supports ICU as well (#28836 (comment))

Commits
-------

3018a7a [Intl] Update timezones to ICU 64.2 + compile zone to country mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants