[Form] Add intltimezone input to TimezoneType#31195
Merged
fabpot merged 1 commit intosymfony:masterfrom Apr 27, 2019
ro0NL:timezone-form
Merged
[Form] Add intltimezone input to TimezoneType#31195fabpot merged 1 commit intosymfony:masterfrom ro0NL:timezone-form
fabpot merged 1 commit intosymfony:masterfrom
ro0NL:timezone-form
Conversation
ro0NL
commented
Apr 22, 2019
|
|
||
| foreach (\DateTimeZone::listIdentifiers($regions) as $timezone) { | ||
| if ('intltimezone' === $input && 'Etc/Unknown' === \IntlTimeZone::createTimeZone($timezone)->getID()) { | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
for reference, the following PHP timezone IDs become unavailable:
America/Punta_Arenas
Asia/Atyrau
Asia/Famagusta
Asia/Qostanay
Asia/Tomsk
Asia/Yangon
Europe/Kirov
Europe/Saratov
(see https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/metaZones.txt for expiration dates)
yceruto
reviewed
Apr 22, 2019
src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php
Outdated
Show resolved
Hide resolved
yceruto
approved these changes
Apr 25, 2019
javiereguiluz
approved these changes
Apr 25, 2019
src/Symfony/Component/Form/Extension/Core/DataTransformer/IntlTimeZoneToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/IntlTimeZoneToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/IntlTimeZoneToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/IntlTimeZoneToStringTransformer.php
Outdated
Show resolved
Hide resolved
xabbuh
added a commit
that referenced
this pull request
Apr 27, 2019
This PR was squashed before being merged into the 3.4 branch (closes #31278). Discussion ---------- [Form] Fix author tag + exception messages | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> spotted in #31195 😅 Commits ------- 796f2ff [Form] Fix author tag + exception messages
fabpot
approved these changes
Apr 27, 2019
Member
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Apr 27, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #31195). Discussion ---------- [Form] Add intltimezone input to TimezoneType | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #22302 (ref #28836) | License | MIT | Doc PR | symfony/symfony-docs#11463 cc @rvanlaak Commits ------- e169dfb [Form] Add intltimezone input to TimezoneType
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @rvanlaak