[DomCrawler] fix HTML5 parser integration #31257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakzal
approved these changes
Apr 26, 2019
|
I don't understand which issue you are trying to solve here. We cannot add content multiple time (as all nodes have to belong to the same document), and calling |
stof
reviewed
Apr 26, 2019
The code makes little sense either: one should not have to know how the overall class works to understand local details. I'm making the code have a better locality so one can reason about it in a simpler way. |
nicolas-grekas
added a commit
that referenced
this pull request
May 9, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [DomCrawler] fix HTML5 parser integration | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted while reviewing #30892 The current logic is context-dependent: by changing the order of calls, you can get different behaviors. Commits ------- ba83bda [DomCrawler] fix HTML5 parser integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while reviewing #30892
The current logic is context-dependent: by changing the order of calls, you can get different behaviors.