Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make error message more clear #31259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2019
Merged

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Apr 26, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

When you get the following error message No transport supports the given DSN "..."., you might think that this relates to a mailer transport or a messenger transport. Let's make this real clear.

Copy link
Contributor

@jakzal jakzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures seem to be legit. Some tests verify exception messages, like this one:

* @expectedExceptionMessage Could not find Doctrine connection from DSN "doctrine://default".

@fabpot fabpot force-pushed the error-message-tweaks branch from ee9fe4f to cdcb6c9 Compare April 27, 2019 16:32
@fabpot
Copy link
Member Author

fabpot commented Apr 27, 2019

Tests fixed

@fabpot fabpot merged commit cdcb6c9 into symfony:master Apr 27, 2019
fabpot added a commit that referenced this pull request Apr 27, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

Make error message more clear

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

When you get the following error message `No transport supports the given DSN "...".`, you might think that this relates to a mailer transport or a messenger transport. Let's make this real clear.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

cdcb6c9 made error message more clear
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot deleted the error-message-tweaks branch May 8, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants