[VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4) #31303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas Ready for review. |
nicolas-grekas
requested changes
Apr 29, 2019
There was a problem hiding this comment.
Thanks, that's good step!
This highlights a PHP7.4 bug, reported as https://bugs.php.net/77951
Let's wait for the issue to be fixed before merging.
linaori
reviewed
Apr 29, 2019
|
The bug has been fixed upstream, let's try again? Can you rerun the tests see if they pass now? |
|
Oh, would you mind doing a benchmark too? I'd be happy to know if the new way works faster than the current one. |
|
In theory, this should work, in practice, tests fail. |
37ee7db to
4078294
Compare
nicolas-grekas
approved these changes
Jul 22, 2019
| @@ -68,8 +68,8 @@ public static function castObject($obj, $class, $hasDebugInfo = false) | |||
| foreach ($a as $k => $v) { | |||
| if (isset($k[0]) ? "\0" !== $k[0] : \PHP_VERSION_ID >= 70200) { | |||
| if (!isset($publicProperties[$class])) { | |||
| foreach (get_class_vars($class) as $prop => $v) { | |||
| $publicProperties[$class][$prop] = true; | |||
| foreach ((new \ReflectionClass($class))->getProperties(\ReflectionProperty::IS_PUBLIC) as $prop) { | |||
There was a problem hiding this comment.
need to account for https://bugs.php.net/78319
|
Thank you @dorumd. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2019
…key is a reference (php >= 7.4) (dorumd, nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31135 | License | MIT | Doc PR | - Prepare for PHP 7.4: use ReflectionReference in VarCloner Commits ------- 40f24ef [VarDumper] finish PHP 7.4 support and add tests e99a6b8 [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
This was referenced Jul 27, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for PHP 7.4: use ReflectionReference in VarCloner