[FrameworkBundle] Show injected services for iterator and array arguments #31353
Conversation
2781480 to
21f7c9a
Compare
|
Should this be done on 3.4 instead? Currently 3.4 shows 0 instead of X in the iterator. This PR can be seen as a bug fix imo |
|
We're too lax currently merging features as bug fixes, introducing regressions actually. Let's be a bit stricter, this is for master to me too. |
|
@nicolas-grekas for the value display, I can agree. The fact that this iterator is showing 0 instead of the actual amount is the initial bug I reported. Perhaps the PR could be split up to put the count fix in 3.4 and the list of services in the master? |
|
@linaori The fact that this iterator is showing 0 in branch @nicolas-grekas Using a compiled container in the DebugContainerCommand was introduced in #27684 I think to fix this |
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
Outdated
Show resolved
Hide resolved
cc3c5d2 to
db5fb20
Compare
|
Thank you @jschaedl. |
…and array arguments (jschaedl) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] Show injected services for iterator and array arguments | Q | A | ------------- | --- | Branch? | master | Bug fix? |no | New feature? | yes<!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31340 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | tbd. When I have the following service configuration: ```yaml App\Word\Checker\StaticWordChecker: tags: [app.checker] App\Word\Checker\BannedWorldListChecker: tags: [app.checker] App\Word\WordCheckerTaggedIterator: arguments: [!tagged app.checker] App\Word\WordCheckerArray: arguments: - App\Word\Checker\StaticWordChecker: ~ App\Word\Checker\BannedWorldListChecker: ~ ``` and I run: `./bin/console debug:container App\Word\WordCheckerArray --show-arguments` ```bash Information for Service "App\Word\WordCheckerArray" =================================================== ---------------- ------------------------------------------- Option Value ---------------- ------------------------------------------- Service ID App\Word\WordCheckerArray Class App\Word\WordCheckerArray Tags - Public no Synthetic no Lazy no Shared yes Abstract no Autowired yes Autoconfigured yes Arguments Array (2 element(s)) - App\Word\Checker\StaticWordChecker - App\Word\Checker\BannedWorldListChecker ---------------- ------------------------------------------- ``` or `./bin/console debug:container App\Word\WordCheckerTaggedIterator --show-arguments` ```bash Information for Service "App\Word\WordCheckerTaggedIterator" ============================================================ ---------------- ------------------------------------------- Option Value ---------------- ------------------------------------------- Service ID App\Word\WordCheckerTaggedIterator Class App\Word\WordCheckerTaggedIterator Tags - Public no Synthetic no Lazy no Shared yes Abstract no Autowired yes Autoconfigured yes Arguments Iterator (2 element(s)) - App\Word\Checker\BannedWorldListChecker - App\Word\Checker\StaticWordChecker ---------------- ------------------------------------------- ``` I can now see the the objects injected into the iterator and array arguments. Commits ------- db5fb20 [FrameworkBundle] Show injected services for Iterator and Array
| } elseif ($argument instanceof ServiceLocatorArgument) { | ||
| $argumentsInformation[] = sprintf('Service locator (%d element(s))', \count($argument->getValues())); | ||
| } elseif ($argument instanceof Definition) { | ||
| $argumentsInformation[] = 'Inlined Service'; | ||
| } else { | ||
| $argumentsInformation[] = \is_array($argument) ? sprintf('Array (%d element(s))', \count($argument)) : $argument; | ||
| if (\is_array($argument)) { | ||
| foreach (array_keys($argument) as $service) { | ||
| $argumentsInformation[] = sprintf('- %s', $service); |
There was a problem hiding this comment.
I reverted this part in 7a53e8d as I don't see how listing keys can be useful.
| @@ -348,12 +348,20 @@ protected function describeContainerDefinition(Definition $definition, array $op | |||
| $argumentsInformation[] = sprintf('Service(%s)', (string) $argument); | |||
| } elseif ($argument instanceof IteratorArgument) { | |||
| $argumentsInformation[] = sprintf('Iterator (%d element(s))', \count($argument->getValues())); | |||
| foreach (array_map(function (Reference $value) {return (string) $value; }, $argument->getValues()) as $service) { | |||
| $argumentsInformation[] = sprintf('- %s', $service); | |||
There was a problem hiding this comment.
since this is a reference, it should be displayed as Service(%s)
fixed in 7a53e8d too
When I have the following service configuration:
and I run:
./bin/console debug:container App\Word\WordCheckerArray --show-argumentsor
./bin/console debug:container App\Word\WordCheckerTaggedIterator --show-argumentsI can now see the the objects injected into the iterator and array arguments.