[Form] Add label_html attribute #31375

przemyslaw-bogusz · 2019-05-03T14:32:46Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT
Doc PR	symfony/symfony-docs#13316

I propose to add a new attribute to BaseType class so it is easy to include html tags in labels for, both, buttons and other elements that inherit from FormType class. This gives you an ability to add, e.g. a glyphicon to a button, or a link to a checkbox, simply inside the FormBuilder, which means you can just do

{{ form(form) }}

inside a template.

Sidenotes

I have started working on this two days ago and it the meantime @alexander-schranz made a similar proposition in [Form] Add label_raw attribute to form theme #31358. If necessary, I can close my PR and @alexander-schranz can include my suggestions inside his PR.
I have just read in [Form][TwigBridge] Add help_html #29861 that @mpiot wanted to include this idea in his PR. With respect to @xabbuh's comments from that PR, I hope that my PR will be at least a good place to discuss, if the proposed feature is a good solution.

alexander-schranz · 2019-05-09T12:45:11Z

As described in #31358 I think it totally make sense to have label_html attribute in it as we also have help_html attribute. 👍 for this.

alexander-schranz · 2019-05-13T07:50:36Z

@przemyslaw-bogusz the label is also used inside the button example and could contain html there also see: https://github.com/symfony/symfony/pull/31358/files

AndreasA · 2019-05-28T05:51:36Z

Hi, just wondering will this make it into Symfony 4.3?

przemyslaw-bogusz · 2019-05-28T06:45:55Z

@AndreasA I've been busy preparing for SymfonyLive in Warsaw, but that's on the list of my priorities, so I will fix the tests and complete it as soon as I can. However, it doesn't mean it will be automatically approved. If you like the idea, give it a 'thumbs up' or leave a positive comment.

AndreasA · 2019-05-28T09:11:08Z

I think this would be really helpful. Especially in combination with the label_translation_parameters it would allow to create terms and condition checkboxes with links in them way easier than it is now.

alexander-schranz · 2019-06-12T12:56:43Z

@przemyslaw-bogusz the tests seems to fail because $label_html is not define in the form_label.html.php not sure how this happens maybe you can try to debug the tests and try to fix it?

przemyslaw-bogusz · 2019-06-17T07:02:21Z

I've tried a different approach by implementing this feature in FormType instead of BaseType, but in either case tests keep failing with the same result - variable "label_html" does not exist. Nevertheless, it works in real application with different combinations of field types and themes. Maybe @xabbuh or @chr-hertel could shed some light?

przemyslaw-bogusz · 2020-02-10T19:30:11Z

@xabbuh I have started working on this some time ago, but I had problem with a single space, that which caused the tests to fail. I have fixed this, but there is still some issue with Travis on PHP 7.4. I could really use some help to solve this out, because there are a few people, who like this proposition - #35598.

xabbuh · 2020-02-14T08:00:03Z

@przemyslaw-bogusz I think making sure that the Twig bridge always gets the Form component in version 5.1 or higher should solve it. We would need to make some changes to the Twid bridge's composer.json file.

require-dev:

"symfony/form": "^5.1"

conflict:

"symfony/form": "<5.1"

przemyslaw-bogusz · 2020-02-14T08:46:53Z

@xabbuh Thanks a lot. That solved the issue. However, now there is a single test in Cache Component failing.

fabpot · 2020-02-15T07:22:56Z

It looks like this PR contains not related commits. Can you rebase and force push?

nicolas-grekas

(I rebased + squashed)

HeahDude

Thanks! We also need a note in the form component CHANGELOG.

przemyslaw-bogusz · 2020-02-15T20:12:33Z

I have updated the form component changelog. Sorry for the mess with the commits and thanks for the cleanup.

src/Symfony/Component/Form/CHANGELOG.md

przemyslaw-bogusz · 2020-02-28T05:43:41Z

I removed the CHANGELOG update, and without AppVeyor CI is green again.

javiereguiluz

Nice and useful feature!

nicolas-grekas · 2020-03-12T17:18:41Z

Thank you @przemyslaw-bogusz.

alexander-schranz · 2020-03-12T17:19:39Z

@przemyslaw-bogusz good work nice to see this merged!

przemyslaw-bogusz · 2020-03-13T09:04:20Z

@alexander-schranz Thanks! I wish you all the best in future PRs.

@przemyslaw-bogusz

…bogusz) This PR was squashed before being merged into the master branch (closes #13316). Discussion ---------- [Form] Add description of label_html option | Q | A | ------------- | --- | Feature PR | symfony/symfony#31375 | PR author(s) | @przemyslaw-bogusz | Merged in | WCM Commits ------- 7a74bb3 [Form] Add description of label_html option

@przemyslaw-bogusz

…rzemyslaw-bogusz) This PR was squashed before being merged into the master branch (closes #13409). Discussion ---------- [Validator] Add description for AtLeastOne constraint | Q | A | ------------- | --- | Feature PR | symfony/symfony#31375 | PR author(s) | @przemyslaw-bogusz | Merged in | 5.1-dev | Fixes | #13355 Commits ------- 5ba5224 [Validator] Add description for AtLeastOne constraint

carsonbot added Status: Needs Review Form Feature labels May 3, 2019

xabbuh mentioned this pull request May 4, 2019

[Form] Add label_raw attribute to form theme #31358

Closed

xabbuh added this to the next milestone May 4, 2019

wouterj mentioned this pull request May 12, 2019

Add documentation for label_raw attribute symfony/symfony-docs#11513

Closed

przemyslaw-bogusz force-pushed the label_html branch from d92e2a8 to 05a1c39 Compare May 29, 2019 15:13

przemyslaw-bogusz force-pushed the label_html branch from 05a1c39 to 5a50ee8 Compare June 16, 2019 19:20

przemyslaw-bogusz changed the base branch from master to 4.4 June 24, 2019 07:15

przemyslaw-bogusz changed the base branch from 4.4 to master June 25, 2019 22:35

przemyslaw-bogusz force-pushed the label_html branch from a23d9eb to fc0ee8f Compare June 25, 2019 23:11

przemyslaw-bogusz requested a review from xabbuh as a code owner June 25, 2019 23:11

przemyslaw-bogusz force-pushed the label_html branch from fc0ee8f to 46f625f Compare June 25, 2019 23:24

przemyslaw-bogusz force-pushed the label_html branch from 2617c46 to b4c0924 Compare February 9, 2020 14:37

przemyslaw-bogusz mentioned this pull request Feb 9, 2020

Form Labels translation does not allow raw content (Add label_html option) #35598

Closed

nicolas-grekas force-pushed the label_html branch from 3fb25c0 to 7037723 Compare February 15, 2020 10:46

nicolas-grekas approved these changes Feb 15, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Feb 15, 2020

HeahDude approved these changes Feb 15, 2020

View reviewed changes

nicolas-grekas reviewed Feb 15, 2020

View reviewed changes

src/Symfony/Component/Form/CHANGELOG.md Outdated Show resolved Hide resolved

przemyslaw-bogusz changed the title ~~[Form] Add label_html attribute~~ [Form] Add label_html attribute test Feb 18, 2020

przemyslaw-bogusz changed the title ~~[Form] Add label_html attribute test~~ [Form] Add label_html attribute Feb 18, 2020

przemyslaw-bogusz force-pushed the label_html branch from 5a25ef1 to ab9f795 Compare February 18, 2020 23:14

przemyslaw-bogusz force-pushed the label_html branch from ab9f795 to 02d9f0b Compare February 27, 2020 22:08

javiereguiluz approved these changes Mar 3, 2020

View reviewed changes

przemyslaw-bogusz mentioned this pull request Mar 8, 2020

[Form] Add description of label_html option symfony/symfony-docs#13316

Merged

[Form] Add label_html attribute

239fe04

nicolas-grekas force-pushed the label_html branch from 02d9f0b to 239fe04 Compare March 12, 2020 17:18

nicolas-grekas merged commit 49e5d57 into symfony:master Mar 12, 2020

przemyslaw-bogusz deleted the label_html branch March 13, 2020 09:04

przemyslaw-bogusz mentioned this pull request Mar 23, 2020

[Validator] Add description for AtLeastOne constraint symfony/symfony-docs#13409

Merged

ThomasLandauer mentioned this pull request Apr 18, 2020

[Form] Implement "label_html" option #8733

Closed

nicolas-grekas modified the milestones: next, 5.1 May 4, 2020

fabpot mentioned this pull request May 5, 2020

Release v5.1.0-BETA1 #36713

Merged

ThomasLandauer mentioned this pull request Apr 24, 2021

[Form]: Add option choice_html to allow HTML content in ChoiceType labels #40806

Closed

gbere mentioned this pull request Jul 5, 2021

BooleanField doesn't work on forms since version 3.4 when using Symfony < 5.1 EasyCorp/EasyAdminBundle#4452

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form] Add label_html attribute #31375

[Form] Add label_html attribute #31375

przemyslaw-bogusz commented May 3, 2019 •

edited

Loading

alexander-schranz commented May 9, 2019 •

edited

Loading

alexander-schranz commented May 13, 2019

AndreasA commented May 28, 2019 •

edited

Loading

przemyslaw-bogusz commented May 28, 2019

AndreasA commented May 28, 2019 •

edited

Loading

alexander-schranz commented Jun 12, 2019

przemyslaw-bogusz commented Jun 17, 2019

przemyslaw-bogusz commented Feb 10, 2020

xabbuh commented Feb 14, 2020

przemyslaw-bogusz commented Feb 14, 2020

fabpot commented Feb 15, 2020

nicolas-grekas left a comment

HeahDude left a comment

przemyslaw-bogusz commented Feb 15, 2020

przemyslaw-bogusz commented Feb 28, 2020

javiereguiluz left a comment

nicolas-grekas commented Mar 12, 2020

alexander-schranz commented Mar 12, 2020

przemyslaw-bogusz commented Mar 13, 2020

[Form] Add label_html attribute #31375

[Form] Add label_html attribute #31375

Conversation

przemyslaw-bogusz commented May 3, 2019 • edited Loading

alexander-schranz commented May 9, 2019 • edited Loading

alexander-schranz commented May 13, 2019

AndreasA commented May 28, 2019 • edited Loading

przemyslaw-bogusz commented May 28, 2019

AndreasA commented May 28, 2019 • edited Loading

alexander-schranz commented Jun 12, 2019

przemyslaw-bogusz commented Jun 17, 2019

przemyslaw-bogusz commented Feb 10, 2020

xabbuh commented Feb 14, 2020

przemyslaw-bogusz commented Feb 14, 2020

fabpot commented Feb 15, 2020

nicolas-grekas left a comment

Choose a reason for hiding this comment

HeahDude left a comment

Choose a reason for hiding this comment

przemyslaw-bogusz commented Feb 15, 2020

przemyslaw-bogusz commented Feb 28, 2020

javiereguiluz left a comment

Choose a reason for hiding this comment

nicolas-grekas commented Mar 12, 2020

alexander-schranz commented Mar 12, 2020

przemyslaw-bogusz commented Mar 13, 2020

przemyslaw-bogusz commented May 3, 2019 •

edited

Loading

alexander-schranz commented May 9, 2019 •

edited

Loading

AndreasA commented May 28, 2019 •

edited

Loading

AndreasA commented May 28, 2019 •

edited

Loading