[Messenger] Fix Redis Connection::get() after reject() #31387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
commented
May 5, 2019
| @@ -123,7 +123,7 @@ public function ack(string $id): void | |||
| } catch (\RedisException $e) { | |||
| } | |||
|
|
|||
| if (!$acknowledged || $e) { | |||
| if ($e || !$acknowledged) { | |||
There was a problem hiding this comment.
unrelated: if $e is not null then $acknowledged is undefined.
fabpot
approved these changes
May 6, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
May 6, 2019
…alasr) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Fix Redis Connection::get() after reject() | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? |no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a If a message is rejected, another consumer cannot read from the stream because the first subsequent call to `\Redis::xreadgroup()` returns false for some reason. Reproducer: https://github.com/chalasr/redis-transport-bug ping @alexander-schranz Commits ------- c05273f [Messenger] Fix Redis Connection::get() after reject()
|
@chalasr for me it looks like we need to call on reject |
|
@alexander-schranz Makes sense, would you mind opening a PR? |
fabpot
added a commit
that referenced
this pull request
May 6, 2019
…chranz) This PR was squashed before being merged into the 4.3-dev branch (closes #31396). Discussion ---------- [Messenger] Fix rejecting of pending messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... | License | MIT | Doc PR | - As discussed in #31387 (comment). It seems pending messages are not removed by calling xdel so we need to call xack first to remove them from the pending state and then call xdel to remove it from the complete stream. It seems to be the correct way as mentioned in: https://github.com/antirez/redis/issues/5754 Test should be the same as added in: https://github.com/symfony/symfony/pull/31387/files#diff-46c1e03dafbcebc46b5cace7d05de20c Commits ------- 072e466 [Messenger] Fix rejecting of pending messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a message is rejected, another consumer cannot read from the stream because the first subsequent call to
\Redis::xreadgroup()returns false for some reason.Reproducer: https://github.com/chalasr/redis-transport-bug
ping @alexander-schranz