[Messenger] fix wrong use of generator returns #31389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
May 6, 2019
| @@ -84,12 +84,12 @@ public function getMessageCount(): int | |||
| return ($this->receiver ?? $this->getReceiver())->getMessageCount(); | |||
| } | |||
|
|
|||
| private function getReceiver() | |||
| private function getReceiver(): AmqpReceiver | |||
There was a problem hiding this comment.
Added typehints to make it consistent with DoctrineTransport.
chalasr
approved these changes
May 6, 2019
|
fabbot patch looks good |
e931367 to
50c9c8a
Compare
xabbuh
approved these changes
May 6, 2019
50c9c8a to
c9e5853
Compare
|
Fixed tests |
|
@Tobion Can you apply fabbot's patch? |
And some other minor cleanups
c9e5853 to
e8a09e9
Compare
|
Done |
sroze
approved these changes
May 6, 2019
xabbuh
approved these changes
May 6, 2019
fabpot
approved these changes
May 6, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
May 6, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] fix wrong use of generator returns | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> I've seen this problem many times: Mixing `yield` with `return []`. Unfortunately it cannot be forbidden at the compiler level because it's actually a feature: https://www.php.net/manual/de/generator.getreturn.php But usually not intended that way. Also added some other minor cleanups I've found. Commits ------- e8a09e9 [Messenger] fix wrong use of generator returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen this problem many times: Mixing
yieldwithreturn [].Unfortunately it cannot be forbidden at the compiler level because it's actually a feature: https://www.php.net/manual/de/generator.getreturn.php
But usually not intended that way.
Also added some other minor cleanups I've found.