[Messenger] On failure retry, make message appear received from original sender #31425
Conversation
4e6848a to
db47a21
Compare
8ad8b4c to
ce9154f
Compare
src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php
Outdated
Show resolved
Hide resolved
| @@ -154,7 +154,7 @@ private function runInteractive(SymfonyStyle $io, bool $shouldForce) | |||
| } | |||
There was a problem hiding this comment.
Why it is only collecting one message at a time a few lines above foreach ($receiver->all(1) as $envelope) {? Wouldn't it be better to batch more messages to avoid querying doctrine for each message?
There was a problem hiding this comment.
Hmm. We could... but I don't see a lot of benefit. This is the interactive mode, and we're asking the user if they want to retry one-by-one. In theory, something else could also be reading from the failure transport at the same time, so getting whatever the latest id is one-by-one seems sensible.
| @@ -51,11 +50,8 @@ public function onMessageFailed(WorkerMessageFailedEvent $event) | |||
| $envelope = $event->getEnvelope(); | |||
|
|
|||
| // avoid re-sending to the failed sender | |||
There was a problem hiding this comment.
I see that it makes sense. Otherwise consuming the failure transport could be an endless loop of processing and failing and requeuing.
But I think it should be explicitly warned in the retry command that the message will be gone after retrying it even if it fails again.
There was a problem hiding this comment.
Yep, exactly. However, the failure transport acts like any normal transport. If the transport has retries configured (by default it does, and the default is 3 tries), the message will be retried 3 times on the failure transport before being discarded. In this PR, I even added some extra info on the retry command that says that this message has already been tried 1/2/3... times on the failure transport previously.
ce9154f to
ecff07b
Compare
|
This should be ready - tests passing - ready for review! |
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
0927cf0 to
62f0bb6
Compare
|
Ready to go again. This is mostly a small fix + some refactoring based on @Tobion's recommendations. The vast majority of the added lines are in a robust new integration test. |
62f0bb6 to
80b5df2
Compare
|
Thank you @weaverryan. |
… from original sender (weaverryan) This PR was squashed before being merged into the 4.3 branch (closes #31425). Discussion ---------- [Messenger] On failure retry, make message appear received from original sender | Q | A | ------------- | --- | Branch? | master (4.3) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31413 | License | MIT | Doc PR | symfony/symfony-docs#11236 Fixes a bug when using the transport-based handler config from #30958. This also adds a pretty robust integration test that dispatches a complex message with transport-based handler config, failures, failure transport, etc - and verifies the correct behavior. Cheers! Commits ------- 80b5df2 [Messenger] On failure retry, make message appear received from original sender
Fixes a bug when using the transport-based handler config from #30958. This also adds a pretty robust integration test that dispatches a complex message with transport-based handler config, failures, failure transport, etc - and verifies the correct behavior.
Cheers!